search

rapidfuzz / RapidFuzz

Rapid fuzzy string matching in Python using various string metrics
https://rapidfuzz.github.io/RapidFuzz/
MIT License
2.61k stars 116 forks source link

Please add support for newer versions of TaskFlow #385

Closed mgorny closed 3 months ago

mgorny commented 3 months ago

RapidFuzz currently allows using only TaskFlow 3.3:

https://github.com/rapidfuzz/RapidFuzz/blob/cb8a1b112ab38d1b1119abb36de7c621bd47322a/CMakeLists.txt#L76

Could you please allow newer versions as well? FWICS 3.7.0 still works fine (or at least builds cleanly and tests pass).

maxbachmann commented 3 months ago

newer versions certainly work. In fact I am packaging with v3.7.0 on pypi. So this is simply an incorrect specification in the cmake file.

maxbachmann commented 3 months ago

Should be fixed

mgorny commented 3 months ago

Thanks! Kinda sucks version ranges don't work there.

maxbachmann commented 3 months ago

Yes I believe due to the compatibility setting of taskflow on minor versions it has to be explicit.

Could probably be a function looping over versions to check them, but I am not super familiär with cmake. So I will look into it when the list gets too long