search

rapidfuzz / RapidFuzz

Rapid fuzzy string matching in Python using various string metrics
https://rapidfuzz.github.io/RapidFuzz/
MIT License
2.61k stars 116 forks source link

Port to scikit-build-core #397

Open maxbachmann opened 1 month ago

maxbachmann commented 1 month ago

@henryiii this is a first attempt at porting to scikit-build-core. It did work on my machine, but still has to be tested on things like android where no cmake wheels are available.

maxbachmann commented 1 month ago

I should have ported over all build system features I was previously using and didn't run into any problems so far.

Can you have a quick look over the build system?

maxbachmann commented 1 month ago

Amazing experience so far. This allows me to get rid of quite a few things in the build system. From a development perspective I am really pleased with the fact that I don't have to delete the _skbuild directory between each build anymore :+1:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.87%. Comparing base (d176f65) to head (0b0e045).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #397 +/- ## ======================================= Coverage 82.87% 82.87% ======================================= Files 46 46 Lines 4496 4496 ======================================= Hits 3726 3726 Misses 770 770 ``` | [Flag](https://app.codecov.io/gh/rapidfuzz/RapidFuzz/pull/397/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/rapidfuzz/RapidFuzz/pull/397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `82.87% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maxbachmann commented 1 month ago

In the released version I generate the cython files and ship them as part of the sdist. These generated files get the cxx file ending and are gitignored. The patch is applied before packing the sdist to remove cython from the dependency list since it's not required if the generated files are packed.

henryiii commented 1 month ago

FYI, 0.10 is out. It takes a bit for it to filter down everywhere (conda takes ~24 hours to pick it up), but just letting you know it's becoming available. :)