inbox refresh and message locking

rapidpro / casepro

Case management dashboard for RapidPro

BSD 3-Clause "New" or "Revised" License

21 stars 31 forks source link

inbox refresh and message locking #220

Closed projectmushroom closed 7 years ago

projectmushroom commented 7 years ago

Lock message whilst it's being worked on
10 second message refresh interval
5 minute message locking
Message lock triggered when opening the following modals: Reply, Bulk Reply, Forward, Open Case
Message in a folder will either be locked or added/removed from of current folder, depending on the action
When User-A has an open modal (Reply, Bulk Reply, Forward, Open Case), User-B's messages will be locked after the 10 second refresh interval
When User-A dismisses/completes the modal, User-B's message will be unlocked or added/removed after the refresh interval
The secondary alert message will only be visible when a user tries to action a currently busy message before the refresh interval runs.
Message lock also triggered when entering a open case, and unlocked when exiting

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 99.441% when pulling ffecd7434bd16f3d7b69e16526c1bfe477d66e29 on praekelt:feature/inbox-refresh-locking into 06c7e129c0a63408f10278732fc9e38aaa57f7d6 on rapidpro:master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 99.979% when pulling 1af100623ba5d84e695b3f4df607beacd167476d on praekelt:feature/inbox-refresh-locking into 06c7e129c0a63408f10278732fc9e38aaa57f7d6 on rapidpro:master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 99.979% when pulling 5a0af78113490d6fc44dc990b92f83772f9bdf2c on praekelt:feature/inbox-refresh-locking into 06c7e129c0a63408f10278732fc9e38aaa57f7d6 on rapidpro:master.

projectmushroom commented 7 years ago

@rowanseymour we've also done testing on a large database, all good

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 445125ac2fad744992367379a201495709efe73c on praekelt:feature/inbox-refresh-locking into b3e04b7d4c395fdc2ebe1c0e140516d2c1f57a3a on rapidpro:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling b669cd91fdf4410f636eb83123e3a8ac08eab5c9 on praekelt:feature/inbox-refresh-locking into b3e04b7d4c395fdc2ebe1c0e140516d2c1f57a3a on rapidpro:master.

projectmushroom commented 7 years ago

@rowanseymour we've made the changes, also fixed the flagged view, it now updates unflagged messages correctly

projectmushroom commented 7 years ago

@rowanseymour As you've mentioned, the message lock is not really necessary since the user can see that those messages are associated with a case anyway. We've removed the message lock/unlock from the existing case view also the auto fade of notices.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 6beca26817e493f388b6310be319aa97e2808d8b on praekelt:feature/inbox-refresh-locking into b3e04b7d4c395fdc2ebe1c0e140516d2c1f57a3a on rapidpro:master.

projectmushroom commented 7 years ago

@rowanseymour we've made the necessary changes

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling e61a5a7a6f1655a52e23522e8bff1ddd02e4a11e on praekelt:feature/inbox-refresh-locking into b3e04b7d4c395fdc2ebe1c0e140516d2c1f57a3a on rapidpro:master.

projectmushroom commented 7 years ago

@rowanseymour thanks Rowan!