search

rapidpro / chpro-microsite

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Featured Accordion #23

Closed mtrythall closed 6 years ago

mtrythall commented 6 years ago

Per Slack:

Featured (Accordion) or something and have it except Photo Cards. Have it be the same as Complex Hero, minus the WYSIWYG text area. It can accept the same styles though. What do you think? That'll be clearer for them. Heroes are getting complicated.

This is a plugin that accepts Photo Cards (currently called Featured Cards). It accepts:

  1. Title
  2. Style (same options as Hero)
  3. Link

There is no image or body copy

You can add Photo Cards to it and they'll appear as an accordion.

screenshot 2018-03-21 12 52 17

mtrythall commented 6 years ago

Tagged you on this @sodevious but let's save it for absolute last.

mtrythall commented 6 years ago

@sodevious Feel free to take a stab at this if you want to mess with Foundation's Accordion at all. Otherwise I'll hit it tomorrow.

mtrythall commented 6 years ago

Forgot about the link at the bottom. @SmileyChris Can you add a link field to the Featured Accordion component similar to what we have on Section?

Thanks!

mtrythall commented 6 years ago

Hey @sodevious - This looks fine. I can see why you went with tabs (we'll consider renaming it).

I only saw a few small issues:

screenshot 2018-04-17 15 42 48

Here, the breakpoint probably needs to happen sooner. I'm OK with wider cards if the text isn't so scrunched and we can avoid the text and plus symbol overlap. That said, there should be right margin or padding on the title to avoid overlap in any situation.

screenshot 2018-04-17 15 44 43

In the second issue, the title and text don't line up. Can you revisit and clean this up please?

mtrythall commented 6 years ago

My test case is here: https://unicef-rapidpro-for-health.herokuapp.com/