rapidpro / chpro-microsite

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Footer should be fixed to the bottom #79

Closed mtrythall closed 6 years ago

mtrythall commented 6 years ago

On short pages (of which there will be few), the footer is high up. It should always be fixed to the bottom.

Careful to respect the off-canvas nav when making this change.

screenshot 2018-04-24 16 22 52
mtrythall commented 6 years ago

Almost there. Have a gap at the bottom of the site now.

screenshot 2018-04-27 22 59 52
mtrythall commented 6 years ago

Can you take a look please?

sodevious commented 6 years ago

@mtrythall what browser is this?

sodevious commented 6 years ago
mtrythall commented 6 years ago

Still seeing this one. Any luck on your end?

sodevious commented 6 years ago

@mtrythall I actually haven't seen it at all yet :cry:

sodevious commented 6 years ago

Was hoping I'd come across it while developing and working on some of these other bugs. Will have to take another stab at testing to find it.

mtrythall commented 6 years ago

Ok. Yeah, I see it on Safari too. I can take a look this weekend too. I just didn't see any element that would be causing it. Everything checked out!

mtrythall commented 6 years ago

I can't reproduce this on crossbrowsertesting.com, so, marking it closed.