search

rapidpro / expressions

Expression parsing and evaluation support
BSD 3-Clause "New" or "Revised" License
4 stars 4 forks source link

fix to show completion pop up in string literal except in functions #10

Closed norkans7 closed 8 years ago

norkans7 commented 8 years ago

Fix to show pop up in every place where the template engine will actually substitute

rowanseymour commented 8 years ago

This still seems like we're doing it backwards. The original idea was that given an input up to the caret like..

Hello " @(SUM

you first call expressionContext to reduce it to @(SUM then you call autoCompleteContext on that to reduce it to SUM

But what it seems we've been doing is calling autoCompleteContext on Hello " @(SUM which then gets confused by "

norkans7 commented 8 years ago

May be we should just change the test we have in here to match that as well

I am wondering if it does not make sense to move all the completions code(https://github.com/nyaruka/rapidpro/blob/master/static/coffee/completions.coffee) from rapidpro to expressions?

I am closing this and making the adjustment on rapidpro, thanks to clarify