search

rapidpro / rapidpro-python

Python client library for the RapidPro API
BSD 3-Clause "New" or "Revised" License
18 stars 27 forks source link

make example uuid an actual uuid #57

Closed czue closed 5 years ago

czue commented 6 years ago

the example uuid in this file is malformed (missing a character) which if you actually try to convert it to a python uuid raises an exception "ValueError: badly formed hexadecimal UUID string"

czue commented 6 years ago

hmm seems this is referenced in more places than I realized. i can update this PR to fix tests at some point but won't do that now.

norkans7 commented 6 years ago

@czue can you fix the failing unit test as well?

czue commented 6 years ago

@norkans7 I had been meaning to come back to this at some point but haven't managed to get it to the top of my priority list. feel free to close out this PR in the meantime if you want. I'm not blocked by anything (though generally think it would be good if the tests used actual UUIDs everywhere, but the scope was beyond just this one place)