search

rapidpro / rapidpro-python

Python client library for the RapidPro API
BSD 3-Clause "New" or "Revised" License
18 stars 27 forks source link

Loosen pytz dependencies #75

Closed chris-erickson closed 3 years ago

chris-erickson commented 3 years ago

Could we expand the pytz dependency? Wondering if this is just a consequence of a quasi-semver problem with the year rolling over.

ERROR: Cannot install -r requirements.txt (line 16) and pytz==2021.1 because these package versions have conflicting dependencies.
The conflict is caused by:
    The user requested pytz==2021.1
    rapidpro-python 2.8.1 depends on pytz<2021.0 and >=2020.4
rowanseymour commented 3 years ago

This must be an old version of the code because requirements.txt is gone and it's all poetry now. Recently releases of pip got stricter about conflicts which was part of the motivation of moving to poetry to make it easier to keep dependencies up to date.

tybritten commented 3 years ago

@rowanseymour This still applies with poetry. "^2020.4" only allows2020.x above 4. If you changed the pyproject.toml to ">=2020.4" it would allow ptz versions of 2021.x as well.

rowanseymour commented 3 years ago

Are you seeing dependency conflicts installing from poetry? If we just want to make sure poetry update always gets the latest pytz, we can change the version to *.

tybritten commented 3 years ago

yeah that works. the issue we hit is we have the newest pytz and rapidpro-python in a project and that's causing the conflict

rowanseymour commented 3 years ago

Ah ok this is installing into another project - made new release at https://pypi.org/project/rapidpro-python/2.8.2/