rapidpro / rapidpro-python

Python client library for the RapidPro API
BSD 3-Clause "New" or "Revised" License
18 stars 27 forks source link

Add support for reverse ordering to contacts and runs #78

Closed norkans7 closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #78 (5e1aabe) into main (204665d) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          672       672           
=========================================
  Hits           672       672           
Impacted Files Coverage Δ
temba_client/v2/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 204665d...5e1aabe. Read the comment docs.

rowanseymour commented 3 years ago

Keen to see how this goes in U-Report.. once we're confident it works, uses the same indexes I think we should document it properly in the API docs.

norkans7 commented 3 years ago

I have been checking on that but I see not much will change since we need to pass the same parameters when we use the cursor. That is why we keep recording all the after and before still