[REVIEW] Community Relaunch Updates

rapidsai-community / notebooks-contrib

RAPIDS Community Notebooks

Apache License 2.0

512 stars 266 forks source link

[REVIEW] Community Relaunch Updates #320

Closed Nicholas-7 closed 3 years ago

Nicholas-7 commented 3 years ago

Updated Community Relaunch branch to resolve outdated functionality and syntax issues discovered and for use with an AWS T4 instance with minimal GPU's.

Nicholas-7 commented 3 years ago

Using Stable - 0.18 these two notebooks do not work. Utilizing an AWS T4 g4dn.xlarge instance Rf_demo: Kernel Dies when trying to train sklearn RF parallely.

skl_rf = sklRF(**skl_rf_params, n_jobs=20)
skl_rf.fit(X_train, y_train)

Weather: The get_date_parts helper function will not allow for an .astype conversion of an object to an int datatype.

Metadata inference failed in `get_date_parts`
Original error is below:
------------------------
ValueError('Could not convert strings to integer type due to presence of non-integer values.')

Salonijain27 commented 3 years ago

@Nicholas-7 please only keep the output from essential cells in the notebooks. This will help to keep the notebooks less cluttered and easy to understand

randerzander commented 3 years ago

@Nicholas-7 please only keep the output from essential cells in the notebooks. This will help to keep the notebooks less cluttered and easy to understand

If this is a longer discussion, this PR is probably not the place for it, but see my comment here, please. cc @taureandyernv

taureandyernv commented 3 years ago

@Nicholas-7 once you update the data locations to the data folder, we should be okay to merge. Thanks for all your help!

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.