search

rapidsai / asvdb

Apache License 2.0
9 stars 4 forks source link

Fixed bug preventing parameterized results from being added in a random order #10

Closed rlratzel closed 3 years ago

rlratzel commented 3 years ago

The code assumed parameterized results were added in the same order as the computed Cartesian product of the param values. If results for param combinations were added in a different order, some results were replaced by null in the JSON. For example, the code previously expected these results to be added in this order:

{'funcName': 'bfs', 'result': 0.012093378696590662, 'argNameValuePairs': [('scale', 10), ('ngpus', 1)]},
{'funcName': 'bfs', 'result': 0.19485003012232482, 'argNameValuePairs': [('scale', 10), ('ngpus', 2)]},
{'funcName': 'bfs', 'result': 0.22938291303580627, 'argNameValuePairs': [('scale', 10), ('ngpus', 4)]},
{'funcName': 'bfs', 'result': 0.30646290094591677, 'argNameValuePairs': [('scale', 10), ('ngpus', 8)]},
{'funcName': 'bfs', 'result': 0.01159052224829793, 'argNameValuePairs': [('scale', 11), ('ngpus', 1)]},
{'funcName': 'bfs', 'result': 0.18941782205365598, 'argNameValuePairs': [('scale', 11), ('ngpus', 2)]},
{'funcName': 'bfs', 'result': 0.23198354698251933, 'argNameValuePairs': [('scale', 11), ('ngpus', 4)]},
{'funcName': 'bfs', 'result': 0.3148591748904437, 'argNameValuePairs': [('scale', 11), ('ngpus', 8)]}

(notice all scale 10 results first, then scale 11). If added in a different order, some result values get replaced with null.

A new test was also added and confirmed to fail prior to the bug fix. The bug fix was made, then the test passed.

For conda, the version number was updated and python 3.8 was added to the list of build variants.