Open bdice opened 4 months ago
Strategically, it may make sense to wait until we publish RAPIDS C++ wheels (https://github.com/rapidsai/build-planning/issues/33). That will reduce the build time impact of adding another Python version -- and we already plan to keep the total amount of testing constant. I think it may be reasonable to target early RAPIDS 24.08 for adding Python 3.12 support.
I think that's a good idea, may as well minimize the impact. Although I should note that we were limiting our Python versions to the same degree even pre-wheels (i.e. when we only had conda builds, so half as many total artifacts to output) so I doubt that the C++ wheels effort materially changes the calculus on how many Python versions we will support at a time.
Here is a proposal for the CI matrix I would recommend for Python 3.12: https://github.com/rapidsai/shared-workflows/pull/213
I have opened a separate issue to track dropping Python 3.9: #88
According to PEP 719, Python 3.13.0 is due out October 1st
This comes out before the RAPIDS 24.10 release, which is currently due October 10th
So it would be ideal to have Python 3.12 supported in RAPIDS by then
I'm working on a rapids-reviser
PR to roll out most of the changes. I'm planning to modify the existing example at https://github.com/rapidsai/rapids-reviser/tree/main/examples/add-python-3.11.
I've also added task lists to the issue description with what I think is a comprehensive list of repos to be updated. Will double-check that with some GitHub searches.
Overview
Python 3.12 was released in October 2023. This issue tracks the work to add support for Python 3.12 to RAPIDS.
In #3, RAPIDS added support for Python 3.11, which was released in RAPIDS 24.04. The work to add Python 3.11 was heavily automated, and that could be done again for Python 3.12 to reduce the load on RAPIDS maintainers.
When should we drop Python 3.9?
Typically RAPIDS has kept the matrix of supported Python minor versions to 2 or 3 versions at a time. When adding Python 3.12, we should probably drop Python 3.9 as well.
SPEC 0 recommended dropping support for Python 3.9 in 2023Q4. Meanwhile, NEP 29 recommended dropping support for Python 3.9 as of Apr 05, 2024. Both of these deadlines have passed and several large Python libraries are now moving towards dropping Python 3.9, so it is probably reasonable to drop Python 3.9 around the same time that we add Python 3.12.
Tasks
Each section should be fully completed before moving to the next section.
CI images
ci-conda
,ci-wheel
,citestwheel
) https://github.com/rapidsai/ci-imgs/pull/137CI workflows
Branch Strategy:
shared-workflows
calledpython-3.12
python-3.12
branchpython-3.12
branchThe above tasks are handled by: https://github.com/rapidsai/shared-workflows/pull/213
RAPIDS repositories
This list is intentionally in RAPIDS dependency order... they'll need to be completed in roughly that order.
For each repo,
.github/workflows/*.yaml
to point to thepython-3.12
branch ofshared-workflows
dependencies.yaml
to add support for Python 3.12.pyproject.toml
files for necessary changes (classifiers, etc.)Most of this is easy to automate with rapids-reviser, and we can copy from this previous migrator for Python 3.11: https://github.com/rapidsai/rapids-reviser/pull/11. We still need to manually review the PRs for missing pieces.
Once all repos are migrated to the
python-3.12
branch, the migration is complete. We mergepython-3.12
into the development branch onshared-workflows
and then open follow-up PRs to each repo to reset the branches to that development branch. This "reset" is simple and should be automated with rapids-reviser.Notes:
The
:latest
image fromci-imgs
is frequently used by CI jobs for building docs and testing notebooks. Be aware that issues may arise in those jobs.