search

rapidsai / build-planning

Tracking for RAPIDS-wide build tasks
https://github.com/rapidsai
0 stars 4 forks source link

Measuring Cython code coverage #93

Open jakirkham opened 3 months ago

jakirkham commented 3 months ago

Most RAPIDS projects measure coverage in Python. Though it appears not all measure code coverage in Cython. However there is lots of Cython code in RAPIDS. So it would be ideal to capture this in our code coverage statistics (as well as uncover parts of Cython code that is not currently covered in tests)

Here is an example from cuML where Cython code coverage was added: https://github.com/rapidsai/cuml/pull/3111

vyasr commented 3 months ago

Do we know whether cuml's code coverage of Cython actually works? Last I checked (admittedly quite a long time ago) the Cython coverage plugin did not work with scikit-build. I would a priori expect similar issues with scikit-build-core.

jakirkham commented 3 months ago

If it doesn't work with scikit-build-core, can we please raise an issue?

vyasr commented 3 months ago

I'm asking because I don't know if it does, but if someone tests it and finds that it doesn't then yes certainly we should raise an issue. I just commented on the corresponding Cython/coverage/Meson issue since it looks like someone almost has that working. If someone has bandwidth to test this, that PR branch would probably be a good place to start if coverage doesn't work with the latest Cython out of the box.