search

rapidsai / crossfit

Metric calculation library
Apache License 2.0
2 stars 6 forks source link

Fix clipping for models with non default padding id and direction #58

Closed VibhuJawa closed 3 months ago

VibhuJawa commented 3 months ago

This PR fixes clipping for models with non default padding ids and direction and fixes the bug that @uahmed93 found.

Context: https://nvidia.slack.com/archives/C064Q7DK8DB/p1720601006980309?thread_ts=1720547568.211359&cid=C064Q7DK8DB

VibhuJawa commented 3 months ago

Closed in favor of: https://github.com/rapidsai/crossfit/pull/66