rapidsai / cucim

cuCIM - RAPIDS GPU-accelerated image processing library
https://docs.rapids.ai/api/cucim/stable/
Apache License 2.0
338 stars 58 forks source link

[QST] isort style: remove force_single_line = True from `setup.cfg`? #25

Closed grlee77 closed 3 years ago

grlee77 commented 3 years ago

What is your question?

When we originally ran isort on the skimage module we used the setting multi_line_output = 0 which results in a fairly compact import style. For example:

https://github.com/rapidsai/cucim/blob/78ca0786c817d12d5d608f97c80b4b0a58137a96/python/cucim/src/cucim/skimage/morphology/__init__.py#L1-L8

but if I rerun isort on that file now, it seems there has been a force_single_line = True setting added to setup.cfg which result in the following more verbose style:

from ._skeletonize import thin
from .binary import binary_closing
from .binary import binary_dilation
from .binary import binary_erosion
from .binary import binary_opening
from .grey import black_tophat
from .grey import closing
from .grey import dilation
from .grey import erosion
from .grey import opening
from .grey import white_tophat
from .greyreconstruct import reconstruction
from .misc import remove_small_holes
from .misc import remove_small_objects
from .selem import ball
from .selem import cube
from .selem import diamond
from .selem import disk
from .selem import octagon
from .selem import octahedron
from .selem import rectangle
from .selem import square
from .selem import star

Can we switch back to force_single_line = False or is there a reason to prefer the single line style? I looked at a few other RAPIDS projects and the style is not uniform across them. cuml does seem to have a single line style, but cudf and cusignal do not.

The clara package here is using the single line style, but the skimage package is not. Whichever one we choose we should make the two consistent!

grlee77 commented 3 years ago

closed by #28