build wheels without build isolation, print sccache stats in builds

rapidsai / cucim

cuCIM - RAPIDS GPU-accelerated image processing library

https://docs.rapids.ai/api/cucim/stable/

Apache License 2.0

356 stars 61 forks source link

build wheels without build isolation, print sccache stats in builds #792

Closed jameslamb closed 4 weeks ago

jameslamb commented 1 month ago

Description

Contributes to https://github.com/rapidsai/build-planning/issues/108 Contributes to https://github.com/rapidsai/build-planning/issues/111

Proposes some small packaging/CI changes, matching similar changes being made across RAPIDS.

removes the use of build isolation in wheel builds
printing sccache stats to CI logs
reducing pip's verbosity in wheel building scripts
using the RAPIDS conventions py_build_{project} and py_rapids_build_{project} in dependencies.yaml
updating to the latest rapids-dependency-file-generator (v1.16.0)

jakirkham commented 1 month ago

One thing we would like to do is move to scikit-build-core: https://github.com/rapidsai/cucim/issues/645

Though that hasn't happened yet

We discussed some package restructuring ( https://github.com/rapidsai/cucim/issues/763 ), which would unblock scikit-build-core

Imagine things get a lot simpler to manage here if we are able to make those changes

jameslamb commented 1 month ago

Imagine things get a lot simpler to manage here if we are able to make those changes

"things" in general, definitely. Those look like good changes that should be made in this project.

But to be clear... the work described in those issues you linked wouldn't materially change the way this PR looks. For example, cuspatial projects already use scikit-build-core and have the wheels split into C++ vs. Python, and the changeset in that repo for this effort was pretty similar: https://github.com/rapidsai/cuspatial/pull/1473

jameslamb commented 4 weeks ago

/merge