rapidsai / cudf

cuDF - GPU DataFrame Library
https://docs.rapids.ai/api/cudf/stable/
Apache License 2.0
8.42k stars 899 forks source link

[BUG] Debug build of libcudf fails with kvikio headers #10703

Closed davidwendt closed 2 years ago

davidwendt commented 2 years ago

Changes from PR #10593 cause the libcudf Debug build to fail with the following errors.

20-114D [229+48+134=410] Building CXX object CMakeFiles/cudf.dir/src/io/utilities/data_sink.cpp.o
FAILED: CMakeFiles/cudf.dir/src/io/utilities/data_sink.cpp.o 
/usr/local/bin/g++ -DCUDF_VERSION=22.06.00 -DCUFILE_FOUND -DJITIFY_PRINT_LOG=0 -DJITIFY_USE_CACHE -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -Dcudf_EXPORTS -I/cudf/cpp/build/_deps/dlpack-src/include -I/cudf/cpp/build/_deps/jitify-src -I/cudf/cpp/include -I/cudf/cpp/build/include -I/cudf/cpp/src -I/conda/envs/rapids/include/rapids/libcudacxx -I/cudf/cpp/build/_deps/thrust-src -I/cudf/cpp/build/_deps/thrust-src/dependencies/cub -I/cudf/cpp/build/_deps/nvcomp-src/include -I/cudf/cpp/build/_deps/kvikio-src/cpp/include -isystem /conda/envs/rapids/include -isystem /usr/local/cuda/include -fdiagnostics-color=always -g -fPIC -Wall -Werror -Wno-unknown-pragmas -Wno-error=deprecated-declarations -Wno-deprecated-declarations -pthread -std=gnu++17 -MD -MT CMakeFiles/cudf.dir/src/io/utilities/data_sink.cpp.o -MF CMakeFiles/cudf.dir/src/io/utilities/data_sink.cpp.o.d -o CMakeFiles/cudf.dir/src/io/utilities/data_sink.cpp.o -c /cudf/cpp/src/io/utilities/data_sink.cpp
In file included from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/shim/cufile.hpp:19,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/defaults.hpp:26,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/buffer.hpp:23,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/file_handle.hpp:30,
                 from /cudf/cpp/src/io/utilities/data_sink.cpp:24:
/cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/utils.hpp: In function ‘off_t kvikio::convert_size2off(std::size_t)’:
/cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/utils.hpp:39:9: error: comparison of integer expressions of different signedness: ‘std::size_t’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
   39 |   if (x >= std::numeric_limits<off_t>::max()) {
      |       ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
20-114D [229+46+136=410] Building CXX object CMakeFiles/cudf.dir/src/io/utilities/datasource.cpp.o
FAILED: CMakeFiles/cudf.dir/src/io/utilities/datasource.cpp.o 
/usr/local/bin/g++ -DCUDF_VERSION=22.06.00 -DCUFILE_FOUND -DJITIFY_PRINT_LOG=0 -DJITIFY_USE_CACHE -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -Dcudf_EXPORTS -I/cudf/cpp/build/_deps/dlpack-src/include -I/cudf/cpp/build/_deps/jitify-src -I/cudf/cpp/include -I/cudf/cpp/build/include -I/cudf/cpp/src -I/conda/envs/rapids/include/rapids/libcudacxx -I/cudf/cpp/build/_deps/thrust-src -I/cudf/cpp/build/_deps/thrust-src/dependencies/cub -I/cudf/cpp/build/_deps/nvcomp-src/include -I/cudf/cpp/build/_deps/kvikio-src/cpp/include -isystem /conda/envs/rapids/include -isystem /usr/local/cuda/include -fdiagnostics-color=always -g -fPIC -Wall -Werror -Wno-unknown-pragmas -Wno-error=deprecated-declarations -Wno-deprecated-declarations -pthread -std=gnu++17 -MD -MT CMakeFiles/cudf.dir/src/io/utilities/datasource.cpp.o -MF CMakeFiles/cudf.dir/src/io/utilities/datasource.cpp.o.d -o CMakeFiles/cudf.dir/src/io/utilities/datasource.cpp.o -c /cudf/cpp/src/io/utilities/datasource.cpp
In file included from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/shim/cufile.hpp:19,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/defaults.hpp:26,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/buffer.hpp:23,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/file_handle.hpp:30,
                 from /cudf/cpp/src/io/utilities/datasource.cpp:23:
/cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/utils.hpp: In function ‘off_t kvikio::convert_size2off(std::size_t)’:
/cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/utils.hpp:39:9: error: comparison of integer expressions of different signedness: ‘std::size_t’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
   39 |   if (x >= std::numeric_limits<off_t>::max()) {
      |       ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
davidwendt commented 2 years ago

@madsbk @vuule

madsbk commented 2 years ago

Will fix, first thing tomorrow!

madsbk commented 2 years ago

@davidwendt please reopen, if https://github.com/rapidsai/kvikio/pull/60 didn't fix the issue.