rapidsai / cudf

cuDF - GPU DataFrame Library
https://docs.rapids.ai/api/cudf/stable/
Apache License 2.0
8.27k stars 884 forks source link

[FEA] Improve/refactor the column wrapper (for testing) #1178

Closed eyalroz closed 5 years ago

eyalroz commented 5 years ago

The column wrapper has several shortcomings in terms of its existing functionality, and some missing functionality.

Examples:

There are also some minor style issues like the use of the word row for indices when a column doesn't have any rows etc.

harrism commented 5 years ago

Please submit a PR for things like this if you feel strongly about them. I don't think we are running into actual usability issues with column_wrapper at this point. I consider all of the above "nice to have", although in practice if they aren't used, they are just adding complexity. I'm going to close this issue for now. Please reopen it if you run into actual problems in testing or if you contribute improvements.