Closed eyalroz closed 5 years ago
Please submit a PR for things like this if you feel strongly about them. I don't think we are running into actual usability issues with column_wrapper at this point. I consider all of the above "nice to have", although in practice if they aren't used, they are just adding complexity. I'm going to close this issue for now. Please reopen it if you run into actual problems in testing or if you contribute improvements.
The column wrapper has several shortcomings in terms of its existing functionality, and some missing functionality.
Examples:
for (auto x& : my_column_wrapper) { do_stuff(); }
(even not via a proxy.std::vector
s (in its method's parameters; on the inside this is not a problemThere are also some minor style issues like the use of the word
row
for indices when a column doesn't have any rows etc.