search

rapidsai / cudf

cuDF - GPU DataFrame Library
https://docs.rapids.ai/api/cudf/stable/
Apache License 2.0
8.06k stars 873 forks source link

[FEA] Unused variable in JNI/Java binding for `readParquet` #12031

Open ttnghia opened 1 year ago

ttnghia commented 1 year ago

This is not a complete FEA but is closed to it. Currently, from Java we pass in a boolean variable binaryToString to JNI readParquet but it is unused after merging https://github.com/rapidsai/cudf/pull/11524. This variable may be used in the future thus we didn't remove it.

This issue is to track that unused variable.

ttnghia commented 1 year ago

CC @sameerz @revans2.

GregoryKimball commented 5 months ago

@revans2 should we remove the variable now?

revans2 commented 5 months ago

We can remove it whenever. It is just a question of finding time to do the code cleanup.