rapidsai / cudf

cuDF - GPU DataFrame Library
https://docs.rapids.ai/api/cudf/stable/
Apache License 2.0
8.42k stars 900 forks source link

[BUG] Issues with `codecov` on `cudf` CI #15783

Open galipremsagar opened 5 months ago

galipremsagar commented 5 months ago

Describe the bug There are various issues with codecov I'm trying to summarize into one master issue.

  1. The codecov/patch custom github action doesn't always seem to be posted on the PR. Last PR that had this posted on was: https://github.com/rapidsai/cudf/pull/15719

    Screenshot 2024-05-20 at 6 53 12 AM
  2. codecov bot seems to have stopped commenting on PRs the diff coverage as it used to:

    Screenshot 2024-05-20 at 6 54 30 AM
  3. The base branch coverage is off by a few lines always because we generate the coverage by running the tests nightly are there any best practices and recommendations from codecov team on how to have a very upto-date base branch coverage?

bdice commented 5 months ago

I had a call with a couple folks from Sentry (who create Codecov), Sabiha and Vlad. We talked through a few topics related to coverage in RAPIDS.

AyodeAwe commented 5 months ago

... We need to check on the GitHub application configuration and make sure it's set up correctly. We should also update to the newer Codecov CLI to upload, and use an organization token to authenticate our uploads. Currently we are using the older Codecov uploader (see the install step and shared-workflows call).

PRs that address this:

bdice commented 5 months ago

Amazing! Thanks @AyodeAwe. I will circle back and try this again soon. I think we may get nightly coverage reports for branch-24.06 since that's currently active in CI, but most new PRs are targeting branch-24.08 so we may be out-of-sync for a while until the 24.06 release is complete and we move our nightly CI runs to branch-24.08.