Open vyasr opened 1 month ago
how about something like
template <class TrieT>
struct _parse_options {
char delimiter;
...
TrieT trie_true;
TrieT trie_false;
TrieT trie_na;
bool multi_delimiter;
};
using parse_options_view = _parse_options<cudf::detail::trie_view>;
struct parse_options : public _parse_options<cudf::detail::optional_trie> {
[[nodiscard]] json_inference_options_view json_view() const { ... }
...
};
cc @vuule
question: It seems a shame that one must repeat most of the fields between
parse_options
andparse_options_view
. Shall we open an issue to discuss whether these should be shared with something like:WDYT?
_Originally posted by @wence- in https://github.com/rapidsai/cudf/pull/15727#discussion_r1609612576_