[FEA][JNI] Move to RMM apis get_current_device_resource_ref and set_current_device_resource_ref

rapidsai / cudf

cuDF - GPU DataFrame Library

https://docs.rapids.ai/api/cudf/stable/

Apache License 2.0

8.25k stars 883 forks source link

[FEA][JNI] Move to RMM apis get_current_device_resource_ref and set_current_device_resource_ref #16673

Open abellina opened 2 weeks ago

abellina commented 2 weeks ago

This change https://github.com/rapidsai/rmm/pull/1661 deprecates the pointer based get_current_device_resource and set_current_device_resource in favor of a non-owning reference based set_current_device_resource_ref and get_current_device_resource_ref.

RMM JNI currently uses the pointer based apis so we want to move to the new _ref versions. I don't think we need to worry about ownership, because we already have a java object tracking a heap allocated memory resource.

harrism commented 2 weeks ago

Thanks for the issue. #1661 does not deprecate anything yet. I'm still experimenting with minimizing how invasive the changes have to be.