Closed pxLi closed 1 week ago
unlike spark-rapids-jni, there is no boost dep in our cudf docker ENV currently https://github.com/rapidsai/cudf/blob/branch-24.10/java/ci/Dockerfile.rocky
cc @mythrocks to help check thanks
Presumably the solution is to just add Boost to the JNI build container?
Alternatively, the choice to always use a system boost was added by @revans2 in https://github.com/rapidsai/cudf/pull/10702, so perhaps he can comment more on whether that's still the right choice. I preserved the behavior in #16640 but as a result I had to install boost into my environment to test. I'm not sure whether that's desirable or not.
Presumably the solution is to just add Boost to the JNI build container?
Alternatively, the choice to always use a system boost was added by @revans2 in #10702, so perhaps he can comment more on whether that's still the right choice. I preserved the behavior in #16640 but as a result I had to install boost into my environment to test. I'm not sure whether that's desirable or not.
We have https://github.com/NVIDIA/spark-rapids-jni/blob/branch-24.10/ci/Dockerfile#L65-L72 in spark-rapids-jni, im still trying to understand whats the minimal required boost version for cudf if install independently thanks
also cc @revans2 for the context, thanks
still trying to understand whats the minimal required boost version for cudf if install independently
The minimum is in the error message, needs Boost 1.58 or later. That's pretty old, so we probably can just install the boost package provided by the standard OS packages to meet this minspec.
Describe the bug after #16640 , pre-merge passed because the CI would install boost as a dep explicitly
the cudf JNI nightly failed cudf_nightly-dev-github run: 1329
Steps/Code to reproduce bug
Expected behavior Pass the compilation
Environment overview (please complete the following information)
docker pull
&docker run
commands usedEnvironment details Please run and paste the output of the
cudf/print_env.sh
script here, to gather any other relevant environment detailsAdditional context Add any other context about the problem here.