Closed rongou closed 4 years ago
USE_NVTX
is actually defunct and redundant. NVTX itself already has a NVTX_DISABLE
macro we should use instead. We should just remove the USE_NVTX
options all together.
Don't we still need a CMake option to turn NVTX on or off?
Describe the bug The top-level
CMakeList.txt
contains aUSE_NVTX
option, but setting it toOFF
has no effect, NVTX traces for libcudf still show up in Nsight Systems.Steps/Code to reproduce bug Run
cmake .. -DUSE_NVTX=OFF
, build libcudf, then profile with nsys. The resulting profile still contains libcudf NVTX events.Expected behavior When setting
USE_NVTX
toOFF
, libcudf should not record NVTX events.Environment overview (please complete the following information)
Environment details
Click here to see environment details