rapidsai / cudf

cuDF - GPU DataFrame Library
https://docs.rapids.ai/api/cudf/stable/
Apache License 2.0
8.43k stars 904 forks source link

[FEA] Extend cudf's replace API `normalize_nans_and_zeros` to accept nested types #9651

Open ttnghia opened 3 years ago

ttnghia commented 3 years ago

Currently, the replace API normalize_nans_and_zeros only accepts a non-nested input column that is either FLOAT32 or FLOAT64 type. As a result, when we want to replace -NaN or -0.0 in a child column of a nested column, we have to manually recursively iterate over all the children columns of the given column, check to see whether the current child column is FLOAT32 or FLOAT64 type before calling to normalize_nans_and_zeros.

We should extend normalize_nans_and_zeros to do this automatically. In other words, it should accept an input column of any type.

github-actions[bot] commented 2 years ago

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] commented 2 years ago

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.