search

rapidsai / cugraph-gnn

Apache License 2.0
9 stars 15 forks source link

Remove NumPy <2 pin #33

Closed seberg closed 2 months ago

seberg commented 3 months ago

This PR removes the NumPy<2 pin which is expected to work for RAPIDS projects once CuPy 13.3.0 is released (CuPy 13.2.0 had some issues preventing the use with NumPy 2).

jakirkham commented 2 months ago

Thanks James! 🙏

For NumPy 2 specifically, we have used the NPY201 rule, which this passes

That said, Ruff includes a few NumPy rules (using NPY would include all of them). These look worthwhile to check as well

Agree it is worth adding these across RAPIDS. For planning & discussion, have opened issue: https://github.com/rapidsai/build-planning/issues/103

jakirkham commented 2 months ago

Going to go ahead and merge as this has been approved

As James notes, we will only know if there are issues once there is CI. That said, this will make it easier to test NumPy 2 on CI to learn those issues early on (so we will have time to work through them)