search

rapidsai / cugraph-gnn

Apache License 2.0
9 stars 15 forks source link

add PR CI for cugraph-pyg and cugraph-dgl #59

Closed jameslamb closed 1 month ago

jameslamb commented 1 month ago

Another steps towards completing the work started in #53

Fixes #15

Contributes to https://github.com/rapidsai/build-planning/issues/111

Proposes changes to get CI running on pull requests for cugraph-pyg and cugraph-dgl

Notes for Reviewers

Workflows for nightly builds and publishing nightly packages are intentionally not included here. See https://github.com/rapidsai/cugraph-gnn/pull/58#discussion_r1806797656

Notebook tests are intentionally not added here... they'll be added in the next PR.

Pulls in changes from these other upstream PRs that had not been ported over to this repo:

jameslamb commented 1 month ago

🥳 this is now ready for review! Thanks very much for all the help @alexbarghi-nv .

bdice commented 1 month ago

It seems like there are opportunities to move from CUDA 12.1 to 12.4 and drop the pytorch channel (in favor of conda-forge) in future work, but this seems close enough to move forward once the questions above are addressed.

jameslamb commented 1 month ago

It seems like there are opportunities to move from CUDA 12.1 to 12.4 and drop the pytorch channel (in favor of conda-forge) in future work, but this seems close enough to move forward once the questions above are addressed.

Yep absolutely! That's a good next step. Thanks for reviewing, I do think we should move it forward once you feel like all your questions have been addressed. The sooner we get CI fully working in this repo, the sooner we can cut all this stuff out of the cugraph / wholegraph repos and work on such problems here, in one place.

jameslamb commented 1 month ago

/merge