Open zbjornson opened 4 years ago
This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.
This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.
This issue has been labeled inactive-90d
due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.
Describe the bug The
min_grad_norm
parameter is unused inBarnes_Hut
tSNE:https://github.com/rapidsai/cuml/blob/640baaee711bdb9d623de768189776dedfd700b6/cpp/src/tsne/barnes_hut.cuh#L44-L58
Steps/Code to reproduce bug (Don't have a repro, found through code review.)
Expected behavior Like exact tSNE, it should terminate early: https://github.com/rapidsai/cuml/blob/640baaee711bdb9d623de768189776dedfd700b6/cpp/src/tsne/exact_tsne.cuh#L127-L136
Environment details (please complete the following information):
Additional context Added a
TODO
comment in #2617.