rapidsai / cuml

cuML - RAPIDS Machine Learning Library
https://docs.rapids.ai/api/cuml/stable/
Apache License 2.0
4.16k stars 526 forks source link

[BUG] Fix Codecov.io Base Reports for PRs #3425

Open mdemoret-nv opened 3 years ago

mdemoret-nv commented 3 years ago

Discovered while working on PR #3338, all of the PRs are currently missing their base reports (PRs can be found here). This started when we switched to a 'squash and merge' strategy for PRs. The last PR with a base report is #3340.

Without an accurate base report, many of the codecov comments are incorrect since it will be showing a report with the wrong PR base. Also, trying to view any PR comparison on codecov.io shows an error. See this and this example.

After looking into this for a bit, I believe the issue is due to the new commit SHA that is created when squashing the PR commit IDs. Since no coverage is uploaded for this new SHA, there is no coverage information in the default branch: branch-0.18.

Some potential fixes:

mdemoret-nv commented 3 years ago

Talked with Ops today about this issue. They are looking into the potential fixes listed and will get back to me later this week.

github-actions[bot] commented 3 years ago

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.