search

rapidsai / cuml

cuML - RAPIDS Machine Learning Library
https://docs.rapids.ai/api/cuml/stable/
Apache License 2.0
4.16k stars 526 forks source link

[BUG] DBSCAN: Fix or remove algorithm flags #4830

Open ahendriksen opened 2 years ago

ahendriksen commented 2 years ago

Describe the bug The DBSCAN algorithm in its current form has some flags that determine the algorithm that is used in the calculation of the vertex degree and adjacency matrix. Currently, both steps have only one algorithm.

The code should be cut down quite a bit more:

  1. The vertex degree step has two mostly similar algorithms for precomputed and other metrics. This could (should?) be unified;
  2. The adj_graph step now has a single algorithm and a separate runner file that is redundant.

Additional context PR https://github.com/rapidsai/cuml/pull/4804 removes the naive versions of the algorithms. Code review: https://github.com/rapidsai/cuml/pull/4804#discussion_r929111815

github-actions[bot] commented 2 years ago

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.