search

rapidsai / cuml

cuML - RAPIDS Machine Learning Library
https://docs.rapids.ai/api/cuml/stable/
Apache License 2.0
4.14k stars 526 forks source link

[BUG] libcuml relies on many deprecated RAFT features #5510

Open bdice opened 1 year ago

bdice commented 1 year ago

Describe the bug Warnings appear throughout the libcuml build pertaining to deprecations in RAFT. I have pasted some examples below and attempted to group them. This isn't a comprehensive list, but it covers most of the types of errors that occur many times. I started to tackle some related warnings in #5509.

Neighbor-related deprecations

.../raft/cpp/include/raft/sparse/neighbors/knn.cuh:27:214: note: '#pragma message: .../raft/cpp/include/raft/sparse/neighbors/knn.cuh is deprecated and will be removed in a future release. Please use the sparse/spatial version instead.'

.../raft/cpp/include/raft/spatial/knn/ball_cover_types.hpp:27:223: note: '#pragma message: .../raft/cpp/include/raft/spatial/knn/ball_cover_types.hpp is deprecated and will be removed in a future release. Please use the raft::neighbors version instead.'

.../raft/cpp/include/raft/spatial/knn/ann_common.h:20:86: note: '#pragma message: .../raft/cpp/include/raft/spatial/knn/ann_common.h is deprecated and will be removed in a future release. Please use the other approximate KNN implementations defined in spatial/knn/*.'

Cluster-related deprecations

.../raft/cpp/include/raft/sparse/hierarchy/common.h:23:226: note: '#pragma message: .../raft/cpp/include/raft/sparse/hierarchy/common.h is deprecated and will be removed in a future release. Please use raft/cluster/single_linkage_types.hpp instead.'

Matrix-related deprecations

.../raft/cpp/include/raft/matrix/math.cuh:22:214: note: '#pragma message: .../raft/cpp/include/raft/matrix/math.cuh is deprecated and will be removed in a future release. Please use versions in individual header files instead.'

.../raft/cpp/include/raft/matrix/matrix.cuh:22:216: note: '#pragma message: .../raft/cpp/include/raft/matrix/matrix.cuh is deprecated and will be removed in a future release. Please use versions in individual header files instead.'

Expected behavior libcuml should build without any warnings from RAFT deprecations.

bdice commented 1 year ago

I filed #5513 to reduce the number of matrix deprecations. The remaining matrix deprecations require code changes.