search

rapidsai / cuml

cuML - RAPIDS Machine Learning Library
https://docs.rapids.ai/api/cuml/stable/
Apache License 2.0
4.26k stars 535 forks source link

CI Fix: use ld_preload to avoid libgomp issue on ARM jobs #5949

Closed dantegd closed 4 months ago

msarahan commented 4 months ago

This makes me uncomfortable as a fix. It is essentially saying "I know that the base environment libgomp is already loaded, so let me ignore the one in my test environment." This kind of seems like conforming to insanity.

I think a better approach might be to figure out why the base environment libgomp is being loaded. Is the test environment activated? If so, does something have bad RPATH stuff? Are libraries being loaded with dlopen anywhere? This is more like saying what sanity is, then figuring out why things are not sane.

dantegd commented 4 months ago

@msarahan you raise a point that is more user error (i.e. mine) than something wrong in the environment, I used the base env libgomp.so by error, I changed it to the libgomp.so in the environment which should be the correct one.

dantegd commented 4 months ago

/merge