rapidsai / cuml

cuML - RAPIDS Machine Learning Library
https://docs.rapids.ai/api/cuml/stable/
Apache License 2.0
4.26k stars 535 forks source link

split up CUDA-suffixed dependencies in dependencies.yaml #5974

Closed jameslamb closed 4 months ago

jameslamb commented 4 months ago

Description

Contributes to https://github.com/rapidsai/build-planning/issues/31

In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g. cudf depending on rmm, not rmm-cu12.

This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in dependencies.yaml.

For more details, see:

Notes for Reviewers

Why target 24.08?

This is targeting 24.08 because:

  1. it should be very low-risk
  2. getting these changes into 24.08 prevents the need to carry around patches for every library in DLFW builds using RAPIDS 24.08
jameslamb commented 4 months ago

Those optional-job-conda-python-tests-cudf-pandas-integration jobs are optional, and breaking in ways unrelated to this PR. Going to queue this for auto-merge whenever that other one gets scheduled.

jameslamb commented 4 months ago

/merge

jameslamb commented 4 months ago

I've updated this based on the suggestions from https://github.com/rapidsai/cudf/pull/16183.

Ran the following to check update-version.sh.

git fetch upstream --tags
ci/release/update-version.sh '24.10.00'

git grep -E '24\.8|24\.08'

That revealed a few other places that needed updates in update-version.sh. Pushed those fixes here as well.

jameslamb commented 4 months ago

Cancelling CI here (and will on other commits in the next 24 hours) to save some CI capacity for other projects that are about to enter code freeze.