rapidsai / cuml

cuML - RAPIDS Machine Learning Library
https://docs.rapids.ai/api/cuml/stable/
Apache License 2.0
4.22k stars 530 forks source link

Dropping CMake install in ARM wheel tests? #6023

Open jakirkham opened 2 months ago

jakirkham commented 2 months ago

It looks like we install CMake in the ARM wheel tests for cuML. This was added in PR: https://github.com/rapidsai/cuml/pull/5507

https://github.com/rapidsai/cuml/blob/990db7190ddbc026dcbf88936a9cd9ad860106fd/ci/test_wheel.sh#L10-L13

The comment here mentions building Treelite from source. However looking at a recent CI log, it appears we just download Treelite binaries

Given this, can we drop this workaround? Or is there more context?

dantegd commented 2 months ago

I think it should be totally fine now, that predates availability of ARM treelite packages indeed.