search

rapidsai / cuml

cuML - RAPIDS Machine Learning Library
https://docs.rapids.ai/api/cuml/stable/
Apache License 2.0
4.26k stars 535 forks source link

Fix for `simplicial_set_embedding` #6043

Closed viclafargue closed 2 months ago

viclafargue commented 3 months ago

Closes https://github.com/rapidsai/cuml/issues/6041 and closes https://github.com/rapidsai/cuml/issues/6035

copy-pr-bot[bot] commented 3 months ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Intron7 commented 3 months ago

@viclafargue Thank you for the fast fix can you rename repulsion_strength into gamma. That the name in UMAP's implementation and would make it easier for people to use it as a dropin replacement

dantegd commented 3 months ago

/ok to test

divyegala commented 2 months ago

/ok to test

divyegala commented 2 months ago

/merge