search

rapidsai / cuml

cuML - RAPIDS Machine Learning Library
https://docs.rapids.ai/api/cuml/stable/
Apache License 2.0
4.25k stars 534 forks source link

Reenable `pytest cuml-dask` for CUDA 12.5 wheel CI tests #6051

Closed divyegala closed 2 months ago

divyegala commented 2 months ago

Reference issue: https://github.com/rapidsai/cuml/issues/6050

jakirkham commented 2 months ago

Seeing some of the tests failing due to NumPy 2 compatibility issues on CI. This is the same thing we have seen elsewhere: https://github.com/rapidsai/cuml/pull/6047#issuecomment-2316017613

Think the reason we are getting NumPy 2 here is there is not a constraint on this dependency in cuML

We are fixing both of these issues in PR: https://github.com/rapidsai/cuml/pull/6031

Have taken the changes in this PR and merged them into PR: https://github.com/rapidsai/cuml/pull/6031

That way we have all the CI fixes and skips in one place so we can hopefully clear out the CI issues in one go

jakirkham commented 2 months ago

Thank you Divye for putting this and issue ( https://github.com/rapidsai/cuml/issues/6050 ) together! 🙏

jakirkham commented 2 months ago

Have tweaked this to reenable the skipped wheel tests so we have somewhere to test and fix this issue

Hope that is ok 🙂

divyegala commented 2 months ago

/merge