search

rapidsai / cuml

cuML - RAPIDS Machine Learning Library
https://docs.rapids.ai/api/cuml/stable/
Apache License 2.0
4.26k stars 535 forks source link

Add support for Python 3.12, update to umap-learn==0.5.6 #6060

Closed jameslamb closed 2 months ago

jameslamb commented 2 months ago

Description

Contributes to https://github.com/rapidsai/build-planning/issues/40

This PR adds support for Python 3.12.

Other changes required for this:

Notes for Reviewers

This is part of ongoing work to add Python 3.12 support across RAPIDS. It temporarily introduces a build/test matrix including Python 3.12, from https://github.com/rapidsai/shared-workflows/pull/213.

A follow-up PR will revert back to pointing at the branch-24.10 branch of shared-workflows once all RAPIDS repos have added Python 3.12 support.

This will fail until all dependencies have been updates to Python 3.12

CI here is expected to fail until all of this project's upstream dependencies support Python 3.12.

This can be merged whenever all CI jobs are passing.

jameslamb commented 2 months ago

Restarted CI here now that there are Python 3.12 packages for raft: https://github.com/rapidsai/raft/pull/2428

Will put this up for review once I see enough of CI passing.

bdice commented 2 months ago

/merge

jameslamb commented 2 months ago

Thanks so much for all the help with this @bdice !

bdice commented 2 months ago

/merge