search

rapidsai / cuml

cuML - RAPIDS Machine Learning Library
https://docs.rapids.ai/api/cuml/stable/
Apache License 2.0
4.25k stars 534 forks source link

fix version in Doxygen docs #6104

Closed jameslamb closed 1 month ago

jameslamb commented 1 month ago

Follow-up to #6103.

In that PR, I'd removed the export RAPIDS_MAJOR_MINOR_VERSION. I realized that this project's Doxygen setup actually expects that to be set in the environment.

https://github.com/rapidsai/cuml/blob/22342aad0ecd327e3140471c479d01d83b932c23/ci/build_docs.sh#L35

https://github.com/rapidsai/cuml/blob/22342aad0ecd327e3140471c479d01d83b932c23/cpp/Doxyfile.in#L41

This fixes that, sorry 😬

jameslamb commented 1 month ago

@jakirkham it looks like your review here wasn't sufficient to merge this.

Would you like me to request that you be added to the ci-codeowners team? You can do that but be excluded from the random round-robin assignment to review packaging PRs, if you'd like.

jameslamb commented 1 month ago

/merge