search

rapidsai / cuml

cuML - RAPIDS Machine Learning Library
https://docs.rapids.ai/api/cuml/stable/
Apache License 2.0
4.25k stars 534 forks source link

devcontainer: replace `VAULT_HOST` with `AWS_ROLE_ARN` #6118

Closed jjacobelli closed 3 weeks ago

jjacobelli commented 1 month ago

This PR is replacing the VAULT_HOST variable with AWS_ROLE_ARN. This is required to use the new token service to get AWS credentials.

jjacobelli commented 3 weeks ago

But I don't understand these changes. Is there a write-up about them I could read?

I don't think there is an issue that I can link here, but we are working on removing our Vault instance to use our new token service to get AWS credentials instead

For example, how is this working when there wasn't a corresponding change in https://github.com/rapidsai/devcontainers/commits/branch-24.12/?

Features in these devcontainers explicitly expect to use vault, I thought: https://github.com/rapidsai/devcontainers/blob/a5bba51e0c21e71e90f8b4c63e96a3c3d2dcdd53/USAGE.md?plain=1#L40

Changes on devcontainers are done in this PR: https://github.com/rapidsai/devcontainers/pull/392

bdice commented 3 weeks ago

/merge

jameslamb commented 3 weeks ago

Ah I see, thanks for the links @jjacobelli (here and the others you sent me privately). Changes make sense to me with that additional context. And thanks @trxcllnt and @bdice for helping with approvals while I was out.