search

rapidsai / cuspatial

CUDA-accelerated GIS and spatiotemporal algorithms
https://docs.rapids.ai/api/cuspatial/stable/
Apache License 2.0
604 stars 152 forks source link

`test_geodataframe.py`'s `test_memory_usage` is failing due to size mismatch #1352

Open jakirkham opened 7 months ago

jakirkham commented 7 months ago

As part of the Python 3.11 bringup, we noticed that test_geodataframe.py's test_memory_usage fails

Namely in Python 3.9 and 3.10 it uses 224 bytes, but in Python 3.11 it uses 228 bytes

https://github.com/rapidsai/cuspatial/blob/59972f6c8d3cfdaac018149c6be802741e392705/python/cuspatial/cuspatial/tests/test_geodataframe.py#L323-L330

Unfortunately in Python these kinds of tests can be pretty flaky as things can change in under-the-hood dependencies (perhaps in Python itself) or do to platform differences, so it might be worth rethinking this test altogether

For now this test is being skipped. Filing this issue to track

This test was originally added in PR ( https://github.com/rapidsai/cuspatial/pull/604 )

harrism commented 7 months ago

Seems a bit problematic to have tests that expect exact data sizes for data structures that might change.