rapidsai / cuspatial

CUDA-accelerated GIS and spatiotemporal algorithms
https://docs.rapids.ai/api/cuspatial/stable/
Apache License 2.0
578 stars 145 forks source link

Enable pytest failures on warnings from cudf (Ensure values being set are casted to the object's type) #1358

Closed mroeschke closed 3 months ago

mroeschke commented 4 months ago

Description

In 24.04, cudf issues a FutureWarning when setting a value to a column would change the data type of the original column. The fix involves casting the original column to the value's type first or vice versa. Could use a second eye on the correct direction to cast if a data type was used intentionally.

Additionally the test suite will now fail when a warning comes from cudf as apart of https://github.com/rapidsai/build-planning/issues/26

Checklist

harrism commented 3 months ago

I am not an expert on Python casts so please get another review before merging. Also, the title of the issue should probably include something about the casting, since the change to enable warnings as failures is a small part of the PR.

thomcom commented 3 months ago

Thanks for your quick updates @isVoid looks good to me.

isVoid commented 3 months ago

/merge