search

rapidsai / cuspatial

CUDA-accelerated GIS and spatiotemporal algorithms
https://docs.rapids.ai/api/cuspatial/stable/
Apache License 2.0
612 stars 154 forks source link

[BUG] demo tests contain deprecated functions #312

Closed Salonijain27 closed 1 year ago

Salonijain27 commented 4 years ago

The demo tests contain functions that have been deprecated from cuspatial. Therefore, the tests do not run

harrism commented 4 years ago

What are the "demo tests"? Can you provide a link?

zhangjianting commented 4 years ago

Python demo code is under python/cuspatial/demos. They were mostly developed last summer and are outdated. Some of these demos can not run out-of-box anyway as they rely on external data. I would suggest remove these demo code as they are not essential to cuspatial as a library.

Alternatively, I am thinking the suitability of creating a new repo outside of cuspatial to host demo codes for apps using both public or private data for performance test. In this way, demo/app code (using C++/Python/Java APIs) does not need to go through code review process by cuspatial team. This may attract more contributors who are more users (including some researchers) rather than developers, or those who do not have sufficient knowledge of cuda/cudf to develop production level code and make direct contributions to cuspatial. As a first step, when I get a chance, I will refactorize some of these outdated demo code and put them on my personal github repo as a new project.

harrism commented 4 years ago

I recommend just putting such notebooks in https://github.com/rapidsai-community/notebooks-contrib

thomcom commented 3 years ago

@Salonijain27 are you referring to the code snippets in python/cuspatial/demos? If so, I agree with Jianting that we should remove them.

thomcom commented 3 years ago

@taureandyernv is talking about creating notebooks from these. Lets delete them and move on with the notebooks work.

github-actions[bot] commented 3 years ago

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

github-actions[bot] commented 3 years ago

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.