fix tests failing due to unsorted results

rapidsai / cuxfilter

GPU accelerated cross filtering with cuDF.

https://docs.rapids.ai/api/cuxfilter/stable/

Apache License 2.0

273 stars 67 forks source link

fix tests failing due to unsorted results #479

Closed AjayThorve closed 1 year ago

AjayThorve commented 1 year ago

This PR:

fixes a couple of tests which were failing due to recent changes, leading to aggregate results being unsorted
resolves docs build failures, which were caused by datashader rendering issues with latest numpy(1.24.3), fixed by adding a pin for numpy (<1.24, similar to the version pins in cugraph). @ajschmidt8, could you check if adding this version pin is fine?

AjayThorve commented 1 year ago

/merge

jakirkham commented 1 year ago

Asked OPS for a review offline

AjayThorve commented 1 year ago

Numpy version 1.24.3 issue with datashader is fixed (https://github.com/holoviz/datashader/pull/1176), but not yet released. Tracking it here, so that the version pin for numpy can be reverted once datashader releases 0.14.5.

raydouglass commented 1 year ago

numpy can be reverted once datashader releases 0.14.5

Since https://github.com/rapidsai/cuxfilter/pull/480 bumps datashader >=0.15, can the numpy upper bound pin be removed now?

AjayThorve commented 1 year ago

@raydouglass I have removed the numpy requirements and updated the datashader version to >=0.15