rapidsai / cuxfilter

GPU accelerated cross filtering with cuDF.
https://docs.rapids.ai/api/cuxfilter/stable/
Apache License 2.0
273 stars 67 forks source link

Require Numba 0.57.0+ & NumPy 1.21.0+ #480

Closed jakirkham closed 1 year ago

jakirkham commented 1 year ago

Align with the rest of RAPIDS on these requirements. Also needed for CUDA 12 support.

jakirkham commented 1 year ago

Could someone please add the "improvement" & "non-breaking" labels?

AjayThorve commented 1 year ago

The docs build is failing, due to an issue where numpy v1.24.3 prevent holoviews to render cuxfilter docs charts, should be fixed in #479 here

bdice commented 1 year ago

The docs build is failing, due to an issue where numpy v1.24.3 prevent holoviews to render cuxfilter docs charts

@AjayThorve Is there an upstream bug in holoviews / numpy that we can link to in that PR so that we know when this limitation is lifted? This is important to track for all of RAPIDS, because cuxfilter is installed by default in the rapids metapackage and users may have environment conflicts that require NumPy 1.24. We've seen NumPy 1.24 compatibility requests for cudf and were able to lift this upper bound.

AjayThorve commented 1 year ago

@AjayThorve Is there an upstream bug in holoviews / numpy that we can link to in that PR so that we know when this limitation is lifted? This is important to track for all of RAPIDS, because cuxfilter is installed by default in the rapids metapackage and users may have environment conflicts that require NumPy 1.24. We've seen NumPy 1.24 compatibility requests for cudf and were able to lift this upper bound.

Hey @bdice, so this issue is already fixed in datashader (https://github.com/holoviz/datashader/pull/1176), although it's not yet part of any release(the latest released datashader version is 0.14.4, and this PR is part of the 0.14.5 milestone). How do you suggest we proceed in this scenario?

jakirkham commented 1 year ago

Can we raise an issue on their repo requesting a release (and link that issue here)?

AjayThorve commented 1 year ago

Have asked for an ETA for release here (https://discourse.holoviz.org/t/module-numpy-has-no-attribute-warnings/5402)

hoxbro commented 1 year ago

We have released datashader 1.15, and are working on adding it to conda-forge here. So hopefully you will soon be unblocked.

ianthomas23 commented 1 year ago

Conda-forge datashader-feedstock v0.15.0 PR has been merged so you should be able to proceed shortly.

jakirkham commented 1 year ago

Thanks all! 🙏

AjayThorve commented 1 year ago

thanks everyone, #479 should fix the CI issues, and this PR should be good to merge after that

AjayThorve commented 1 year ago

@jakirkham can you rebase with default branch, that should fix the CI failures

jakirkham commented 1 year ago

Toggling for CI

AjayThorve commented 1 year ago

Please update dependencies.yaml to align. We need numpy and numba pinnings and to make the run section align with the conda list of run dependencies:

@bdice, I pushed the requested changes

AjayThorve commented 1 year ago

/merge

jakirkham commented 1 year ago

Thanks all! 🙏