search

rapidsai / cuxfilter

GPU accelerated cross filtering with cuDF.
https://docs.rapids.ai/api/cuxfilter/stable/
Apache License 2.0
272 stars 67 forks source link

Check compatability with cuDF pandas 2.0 migration #512

Closed exactlyallan closed 6 months ago

exactlyallan commented 1 year ago

Per https://github.com/rapidsai/cudf/pull/13535 check cuxfilter for issues with Pandas 2.0.

jakirkham commented 6 months ago

Recently cuDF added Pandas 2.x support with PR ( https://github.com/rapidsai/cudf/pull/14916 ). This introduced some breaking changes. Given this, it might be worth checking how cuxfilter is working with cuDF following that upgrade

bdice commented 6 months ago

CI is passing in https://github.com/rapidsai/cuxfilter/pull/568, so it's possible that no changes are needed.

galipremsagar commented 6 months ago

CI is passing in #568, so it's possible that no changes are needed.

It's targeted to 24.02, which is still pandas-1.5.x. So we still need someone to investigate it on 24.04

bdice commented 6 months ago

🤦‍♂️ Good eye, @galipremsagar! However, CI also passed yesterday on the CUDA 12.2 PR https://github.com/rapidsai/cuxfilter/pull/563 which targets 24.04. That PR included cudf 24.04.00a356 (build cuda12_py310_240206_g20ed009003_356) and pandas 2.1.4. This was re-run yesterday so I think it's still a sign nothing is needed here?

jakirkham commented 6 months ago

Based on offline discussion with Ajay, sounds like there is work still needed. He is looking into it

jakirkham commented 6 months ago

WIP fix submitted as PR: https://github.com/rapidsai/cuxfilter/pull/569