search

rapidsai / cuxfilter

GPU accelerated cross filtering with cuDF.
https://docs.rapids.ai/api/cuxfilter/stable/
Apache License 2.0
272 stars 67 forks source link

updates to external tests #547

Closed AjayThorve closed 10 months ago

AjayThorve commented 10 months ago

This PR resolves the external tests still failing: https://github.com/rapidsai/cuxfilter/actions/runs/6485671242/job/17612261430.

Basically separately installing direct dependencies and then installing indirect dependencies from dependencies.yaml was downgrading rapids versions to 23.08 separately. This PR updates the dependencies to be in a single place (external_dependencies.yaml), while also adding it to ci/release/update-version.sh

There were a couple of dask.array tests in datashader which were failing when using pytest with --numprocesses flag, which is resolved here by separately running that test without the flag.

cc @exactlyallan

AjayThorve commented 10 months ago

/merge

AjayThorve commented 10 months ago

Approving since the external_dependencies.yaml file already exists.

But, a future enhancement should be to move the external dependencies env file to be a file key in dependencies.yaml instead.

I'll do a follow up PR with this, thanks!