rapidsai / cuxfilter

GPU accelerated cross filtering with cuDF.
https://docs.rapids.ai/api/cuxfilter/stable/
Apache License 2.0
272 stars 66 forks source link

refactor CUDA versions in dependencies.yaml #562

Closed jameslamb closed 6 months ago

jameslamb commented 6 months ago

Description

Contributes to https://github.com/rapidsai/build-planning/issues/7.

Proposes splitting the cuda-version dependency in dependencies.yaml out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

Benefits of this change

jameslamb commented 6 months ago

1 build, conda-python-tests / tests (11.4.3, centos7, amd64, 3.9, v100, earliest), is failing with stuff like this

INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/opt/conda/envs/test/lib/python3.9/site-packages/xdist/workermanage.py", line 386, in process_from_remote
INTERNALERROR>     warning_message = unserialize_warning_message(
...
INTERNALERROR>   File "/opt/conda/envs/test/lib/python3.9/asyncio/events.py", line 642, in get_event_loop
INTERNALERROR>     raise RuntimeError('There is no current event loop in thread %r.'
INTERNALERROR> RuntimeError: There is no current event loop in thread 'Dummy-8'.

(build link)

Not sure if it's relevant, but that is the only job in the matrix testing with an older driver.

I tried adding the CTK back to the environment for that job: https://github.com/rapidsai/cuxfilter/pull/562/commits/9ce9fc8094e14cc8d09b05436f39ad94470caa80.

Let's see if it helps.

jameslamb commented 6 months ago

From discussion offline with @AjayThorve ... I just pushed https://github.com/rapidsai/cuxfilter/pull/562/commits/84ce513bd76f0dfe68a673363b53f73d1b20d0e2 putting a ceiling on panel.

I did this in the bluntest way possible (applying it to all conda envs and pyproject.toml) just to test if it fixes the problem, but that might not be ideal. I'm especially skeptical of the pyproject.toml change... if that makes it out into wheels that users install, having a ceiling on panel is going to be disruptive.

If this works, I'm planning to remove that ceiling from pyproject.toml, do you agree @AjayThorve ?

AjayThorve commented 6 months ago

If this works, I'm planning to remove that ceiling from pyproject.toml, do you agree @AjayThorve ?

Yeah if this works, there haven't been any issues with other envs, and seems like the issue is running parallet pytests with updated panel is causing it. In that case, all we need to do is remove the current upper pin for panel from run dependencies and add a specific panel dependency with >=1.0,<1.3.4 to test_python section (under just conda)

AjayThorve commented 6 months ago

/merge