search

rapidsai / cuxfilter

GPU accelerated cross filtering with cuDF.
https://docs.rapids.ai/api/cuxfilter/stable/
Apache License 2.0
272 stars 66 forks source link

Add support for Python 3.11 #572

Closed jameslamb closed 4 months ago

jameslamb commented 4 months ago

Description

Contributes to https://github.com/rapidsai/build-planning/issues/3

This PR adds support for Python 3.11.

Notes for Reviewers

This is part of ongoing work to add Python 3.11 support across RAPIDS.

The Python 3.11 CI workflows introduced in https://github.com/rapidsai/shared-workflows/pull/176 are optional... they are not yet required to run successfully for PRs to be merged.

This PR can be merged once all jobs are running successfully (including the non-required jobs for Python 3.11). The CI logs should be verified that the jobs are building and testing with Python 3.11.

See https://github.com/rapidsai/shared-workflows/pull/176 for more details.

jakirkham commented 4 months ago

Since Python 3.11 requires NumPy 1.23 at a minimum ( https://github.com/rapidsai/cucim/pull/704#issuecomment-1967552641 ), should we update lines like this?

https://github.com/rapidsai/cuxfilter/blob/3185ae3654fb74d3f1fecea15e5b92993fdf8539/dependencies.yaml#L174

jakirkham commented 4 months ago

/merge

jakirkham commented 4 months ago

Thanks James! 🙏

jakirkham commented 4 months ago

Also handling the NumPy 1.23 requirement in PR: https://github.com/rapidsai/cuxfilter/pull/574