Closed AyodeAwe closed 2 months ago
Converting this back to draft until the issues are fixed.
Looking at the logs today, I realized this is not failing for any build-time reasons. It's just test failures 🤔
Like this:
FAILED cuxfilter/tests/charts/deckgl/test_deckgl.py::TestDeckGL::test_init[cux_df1] - TypeError: __init__() got an unexpected keyword argument 'as_index'
I strongly suspect that isn't related to the changes on this PR, and that that'll block any PR into cuxfilter
until it's resolved.
It looks like cuxfilter has a few test failures related to the dask-expr migration in dask.dataframe
. Most of the migration issues are being tracked in https://github.com/rapidsai/cudf/issues/15027
I'll add a note about cuxfilter
to that meta issue, and will investigate as soon as I can.
In the mean time, it should be fine to set the following environment variable in CI (before dask.dataframe
is ever imported):
export DASK_DATAFRAME__QUERY_PLANNING=False
(This is what cugraph is currently doing).
Thanks for the fixes in #593! Just merged them in here. If that fixes CI here I'll put this up for review.
Alright this looks good! @AjayThorve I think this could be merged. Let me know if you have any other questions or concerns about what it's trying to accomplish.
/merge
Contributes to https://github.com/rapidsai/build-planning/issues/54
Ensures that conda builds will fail in the presence of multiple packages with identical paths