search

rapidsai / dask-build-environment

Build environments for various dask related projects on gpuCI
4 stars 11 forks source link

Unpin py-xgboost in dask-sql CI #87

Closed charlesbluca closed 8 months ago

charlesbluca commented 9 months ago

This unblocks the build failures that result from the addition of py-xgboost=1.7.0 to dask-sql's 3.9 environment in https://github.com/dask-contrib/dask-sql/pull/1301.

jakirkham commented 9 months ago

Could we move to XGBoost 2?

charlesbluca commented 8 months ago

I think so, testing this out against CI here: https://github.com/dask-contrib/dask-sql/pull/1314

If things pass there can go ahead and merge and close this

jakirkham commented 8 months ago

Looks like things passed for Dask-SQL based on Charles' testing. Approving

charlesbluca commented 8 months ago

Thanks @jakirkham! I'm going to retry the dask-sql builds locally to see if https://github.com/dask-contrib/dask-sql/pull/1314 unblocks things, if so should be good to close this

jakirkham commented 8 months ago

Certainly merge at your discretion 🙂

charlesbluca commented 8 months ago

Verified that with https://github.com/dask-contrib/dask-sql/pull/1314 and https://github.com/rapidsai/dask-build-environment/pull/88, builds should be unblocked - closing this out